Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proper ARIA management for hidden and disabled states #1649

Open
wants to merge 1 commit into
base: dev-master
Choose a base branch
from
Open

Add proper ARIA management for hidden and disabled states #1649

wants to merge 1 commit into from

Conversation

gerardkcohen
Copy link
Contributor

This simple pull request adds ARIA state management to Widget's _uiSetVisible and _uiSetDisabled methods by setting the aria-hidden and aria-disabled attributes in order to properly communicate these states to assitistive technology users.

Doc's and unit tests are updated.

@juandopazo
Copy link
Member

Looks good! Do we know if the way screen readers read these attributes is generic enough to be on Widget?

@gerardkcohen
Copy link
Contributor Author

I went back and forth with this question before I made the PR and I was hoping you would be the tie breaker. But honestly, there are no generics with the screen reader. If aria-hidden, it's not communicated. If aria-disabled, its announced as such and it cannot be interacted with. There is not much left to the developer to decided, as in the case with the CSS needed to support these states. If the classes are meant to support/ communicate state, then we really need to provide the same to AT. There is also the potential conflict between the focused and disabled state, as disabled elements may not be focusable, but that is a different conversation.

@juandopazo
Copy link
Member

That's what I was expecting to hear. 👍 from my side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants